xushiyan commented on code in PR #7410:
URL: https://github.com/apache/hudi/pull/7410#discussion_r1089605311
##########
hudi-common/src/main/java/org/apache/hudi/common/table/cdc/HoodieCDCExtractor.java:
##########
@@ -267,7 +267,7 @@ private HoodieCDCFileSplit parseWriteStat(
FileSlice beforeFileSlice = new FileSlice(fileGroupId,
writeStat.getPrevCommit(), beforeBaseFile, Collections.emptyList());
cdcFileSplit = new HoodieCDCFileSplit(instantTs, BASE_FILE_DELETE,
new ArrayList<>(), Option.empty(), Option.of(beforeFileSlice));
} else if (writeStat.getNumUpdateWrites() == 0L &&
writeStat.getNumDeletes() == 0
- && writeStat.getNumWrites() == writeStat.getNumInserts()) {
+ && writeStat.getNumWrites() > 0) {
Review Comment:
can you explain this change pls? this is fixing some corner case?
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/cdc/HoodieCDCRDD.scala:
##########
@@ -157,7 +154,7 @@ class HoodieCDCRDD(
split.changes.last.getInstant,
recordKeyField,
preCombineFieldOpt,
- usesVirtualKeys = false,
+ usesVirtualKeys = !populateMetaFields,
Review Comment:
this is a fix among those renaming changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
