xushiyan commented on code in PR #7410:
URL: https://github.com/apache/hudi/pull/7410#discussion_r1089636397
##########
hudi-common/src/main/java/org/apache/hudi/common/table/cdc/HoodieCDCExtractor.java:
##########
@@ -267,7 +267,7 @@ private HoodieCDCFileSplit parseWriteStat(
FileSlice beforeFileSlice = new FileSlice(fileGroupId,
writeStat.getPrevCommit(), beforeBaseFile, Collections.emptyList());
cdcFileSplit = new HoodieCDCFileSplit(instantTs, BASE_FILE_DELETE,
new ArrayList<>(), Option.empty(), Option.of(beforeFileSlice));
} else if (writeStat.getNumUpdateWrites() == 0L &&
writeStat.getNumDeletes() == 0
- && writeStat.getNumWrites() == writeStat.getNumInserts()) {
+ && writeStat.getNumWrites() > 0) {
Review Comment:
it's inference case because `HoodieCDCExtractor` is all about inferring CDC
result from commit metadata in different scenarios.
I prefer more concise name over lengthy name that gives the same meaning.
anyway are you filing a separate PR for the fixes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
