danny0405 commented on code in PR #7608:
URL: https://github.com/apache/hudi/pull/7608#discussion_r1089858754
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -68,12 +72,12 @@ public class HoodieTableFactory implements
DynamicTableSourceFactory, DynamicTab
@Override
public DynamicTableSource createDynamicTableSource(Context context) {
Configuration conf =
FlinkOptions.fromMap(context.getCatalogTable().getOptions());
- ResolvedSchema schema = context.getCatalogTable().getResolvedSchema();
- sanityCheck(conf, schema);
- setupConfOptions(conf, context.getObjectIdentifier(),
context.getCatalogTable(), schema);
-
Path path = new Path(conf.getOptional(FlinkOptions.PATH).orElseThrow(() ->
new ValidationException("Option [path] should not be empty.")));
+ setupTableOptions(conf.getString(FlinkOptions.PATH), conf);
+ ResolvedSchema schema = context.getCatalogTable().getResolvedSchema();
+ sourceSanityCheck(conf, schema);
+ setupConfOptions(conf, context.getObjectIdentifier(),
context.getCatalogTable(), schema);
Review Comment:
The sanity check for source can be removed. When the primary key definition
is missing, the streaming source for MOR table would distinguish the case as
pk-less, so no deletes are emitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
