alexeykudinkin commented on code in PR #7769:
URL: https://github.com/apache/hudi/pull/7769#discussion_r1089880703
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -236,29 +236,33 @@ private Option<HoodieRecord>
prepareRecord(HoodieRecord<T> hoodieRecord) {
// If the format can not record the operation field, nullify the DELETE
payload manually.
boolean nullifyPayload =
HoodieOperation.isDelete(hoodieRecord.getOperation()) &&
!config.allowOperationMetadataField();
recordProperties.put(HoodiePayloadProps.PAYLOAD_IS_UPDATE_RECORD_FOR_MOR,
String.valueOf(isUpdateRecord));
- Option<HoodieRecord> finalRecord = nullifyPayload ? Option.empty() :
Option.of(hoodieRecord);
+
+ Option<HoodieRecord> finalRecordOpt = nullifyPayload ? Option.empty() :
Option.of(hoodieRecord);
// Check for delete
- if (finalRecord.isPresent() && !finalRecord.get().isDelete(schema,
recordProperties)) {
- // Check for ignore ExpressionPayload
- if (finalRecord.get().shouldIgnore(schema, recordProperties)) {
- return finalRecord;
+ if (finalRecordOpt.isPresent() && !finalRecordOpt.get().isDelete(schema,
recordProperties)) {
+ HoodieRecord finalRecord = finalRecordOpt.get();
+ // Check if the record should be ignored (special case for
[[ExpressionPayload]])
+ if (finalRecord.shouldIgnore(schema, recordProperties)) {
+ return finalRecordOpt;
}
- // Convert GenericRecord to GenericRecord with hoodie commit metadata
in schema
- HoodieRecord rewrittenRecord = schemaOnReadEnabled ?
finalRecord.get().rewriteRecordWithNewSchema(schema, recordProperties,
writeSchemaWithMetaFields)
- : finalRecord.get().rewriteRecord(schema, recordProperties,
writeSchemaWithMetaFields);
+
+ // Prepend meta-fields into the record
Review Comment:
This is primary change in this file: instead of the sequence:
- `rewriteRecord`/`rewriteRecordWithNewSchema` (rewriting record into
schema bearing meta-fields)
- `updateMetadataValues`
we call directly `prependMetaFields` API (expanding record's schema w/
meta-fields and setting them at the same time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
