codope commented on code in PR #7394:
URL: https://github.com/apache/hudi/pull/7394#discussion_r1093257011
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala:
##########
@@ -206,6 +206,18 @@ object HoodieWriterUtils {
}
}
+ /**
+ * In some contexts table config and the datasource write config are
interchangeable.
+ * This is not usually the case so don't use this unless you are sure it is
ok.
+ * */
+ def fixKeyGeneratorClassConfig(params: Map[String, String]): Map[String,
String] = {
Review Comment:
how about make it private?
Also, can you rename to something like `inferKeyGeneratorClassConfig`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
