stream2000 opened a new pull request, #7826:
URL: https://github.com/apache/hudi/pull/7826

   ### Change Logs
   
   There are 2 steps to getInstantsToRollback for lazy clean 
   1. get all inflight instants excluding compaction and clustering 
   2. check whether the heartbeat for the instant is expired. if true, add it 
to the result of instantsToRollback
   
   This approach will cause a problem. If the instant is completed after step 
1, the heartbeat file of the instant will be deleted. 
   Then the instant will be counted as an expired instant, and included in the 
result of instantsToRollback, which is a fatal error. 
   
   We fixed it by adding an extra step 3. After checking whether the heartbeat 
is expired, we reload the active timeline and check if the expired instant is 
an inflight instant. 
   
   ### Impact
   
   fix lazy clean schedule rollback on completed instant
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to