yanghua commented on a change in pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#discussion_r428506563
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/fs/inline/TestInLineFileSystemHFileInLining.java
##########
@@ -40,18 +42,18 @@
import java.util.Set;
import java.util.UUID;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.FILE_SCHEME;
-import static org.apache.hudi.common.fs.inline.FileSystemTestUtils.RANDOM;
-import static
org.apache.hudi.common.fs.inline.FileSystemTestUtils.getPhantomFile;
-import static
org.apache.hudi.common.fs.inline.FileSystemTestUtils.getRandomOuterInMemPath;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.FILE_SCHEME;
+import static org.apache.hudi.common.testutils.FileSystemTestUtils.RANDOM;
+import static
org.apache.hudi.common.testutils.FileSystemTestUtils.getPhantomFile;
+import static
org.apache.hudi.common.testutils.FileSystemTestUtils.getRandomOuterInMemPath;
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
/**
* Tests {@link InLineFileSystem} to inline HFile.
*/
-public class TestHFileInLining {
+public class TestInLineFileSystemHFileInLining {
Review comment:
Can we rename to `TestInLineFileSystem`?
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/fs/inline/TestInLineFileSystemHFileInLining.java
##########
@@ -60,7 +62,7 @@
private int maxRows = 100 + RANDOM.nextInt(1000);
private Path generatedPath;
- public TestHFileInLining() {
+ public TestInLineFileSystemHFileInLining() {
Review comment:
ditto
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestRocksDBDAO.java
##########
@@ -45,7 +45,7 @@
/**
* Tests RocksDB manager {@link RocksDBDAO}.
*/
-public class TestRocksDBManager {
+public class TestRocksDBDAO {
Review comment:
I would recommend renaming `RocksDBDAO ` to be `RocksDBManager`. WDYT?
Generally, `xxxDAO` exists in the web project. cc @vinothchandar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
