alexeykudinkin commented on code in PR #7849:
URL: https://github.com/apache/hudi/pull/7849#discussion_r1096577976
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -80,21 +80,11 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O>
create(
TaskContextSupplier taskContextSupplier,
Option<BaseKeyGenerator> keyGeneratorOpt) {
if (table.requireSortedRecords()) {
- if (table.getMetaClient().getTableConfig().isCDCEnabled()) {
- return new HoodieSortedMergeHandleWithChangeLog<>(writeConfig,
instantTime, table, keyToNewRecords, partitionPath, fileId,
- dataFileToBeMerged, taskContextSupplier, keyGeneratorOpt);
Review Comment:
@YannByron understand the intent, but capturing "compaction" in the name
doesn't make sense. I see we capture in the java-doc that this method is meant
for Compaction, that should be sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
