yihua commented on code in PR #7854:
URL: https://github.com/apache/hudi/pull/7854#discussion_r1096601100
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -75,14 +73,6 @@
* @see HoodieTableMetaClient
* @since 0.3.0
*/
-@ConfigClassProperty(name = "Table Configurations",
Review Comment:
Removing annotation for `HoodieTableConfig` so they do not show up on the
configuration page, as these are not meant to be changed by the user.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -59,10 +59,11 @@
* Indexing related config.
*/
@Immutable
-@ConfigClassProperty(name = "Index Configs",
+@ConfigClassProperty(name = "Common Index Configs",
groupName = ConfigGroups.Names.WRITE_CLIENT,
- description = "Configurations that control indexing behavior, "
- + "which tags incoming records as either inserts or updates to older
records.")
+ subGroupName = ConfigGroups.SubGroupNames.INDEX,
+ areCommonConfigs = true,
+ description = "")
Review Comment:
Note that the description of common configs under a subgroup is moved to
`ConfigGroups.SubGroupNames` enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
