xushiyan commented on code in PR #7856:
URL: https://github.com/apache/hudi/pull/7856#discussion_r1096786491
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -463,6 +463,9 @@ object DataSourceWriteOptions {
val RECONCILE_SCHEMA: ConfigProperty[Boolean] =
HoodieCommonConfig.RECONCILE_SCHEMA
+ val MERGE_INTO_WRITES = "hoodie.merge.into.writes"
Review Comment:
this can go to HoodieSparkSqlWriter L89 just below `CANONICALIZE_NULLABLE`,
which is another internal config
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -463,6 +463,9 @@ object DataSourceWriteOptions {
val RECONCILE_SCHEMA: ConfigProperty[Boolean] =
HoodieCommonConfig.RECONCILE_SCHEMA
+ val MERGE_INTO_WRITES = "hoodie.merge.into.writes"
+ val DEFAULT_MERGE_INTO_WRITES = "false"
Review Comment:
`hoodie.internal.write.sql.is.mergeinto` aligns better with the other
internal config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
