nsivabalan commented on a change in pull request #1647:
URL: https://github.com/apache/incubator-hudi/pull/1647#discussion_r428967198
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -416,10 +425,12 @@ public DeltaSync getDeltaSync() {
jssc.setLocalProperty("spark.scheduler.pool",
SchedulerConfGenerator.DELTASYNC_POOL_NAME);
}
try {
+ int iteration = 1;
while (!isShutdownRequested()) {
try {
long start = System.currentTimeMillis();
- Option<String> scheduledCompactionInstant = deltaSync.syncOnce();
+ HoodieMetrics.setTableName(cfg.metricsTableName + "_" +
iteration);
Review comment:
sorry, I don't quite get why we need to set table name here? Next line
will in turn rely on the arg passed for tablename. So, don't really understand
why we need static fix (i.e. setTableName). From the diff, I see that
cfg.tableName is set passed into DeltaSync.syncOnce(tblName) and
HoodieDeltaStreamerMetrics(HoodieWriteConfig tableName). Can you help me
understand the case where the static set method for table name is required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
