yihua commented on code in PR #7873:
URL: https://github.com/apache/hudi/pull/7873#discussion_r1098128758
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -203,6 +203,17 @@ object HoodieDatasetBulkInsertHelper
.values
}
+ override protected def deduceShuffleParallelism(input: DataFrame,
configuredParallelism: Int): Int = {
+ val deduceParallelism = super.deduceShuffleParallelism(input,
configuredParallelism)
+ // NOTE: In case parallelism deduction failed to accurately deduce
parallelism level of the
+ // incoming dataset we fallback to default parallelism level set for
this Spark session
+ if (deduceParallelism > 0) {
+ deduceParallelism
+ } else {
+ input.sparkSession.sparkContext.defaultParallelism
Review Comment:
Could you add a follow-up for unit-testing such a case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
