danny0405 opened a new pull request, #7874:
URL: https://github.com/apache/hudi/pull/7874

   ### Change Logs
   
   In HoodieMergeHandle, there is such a code snippet:
   
   ```java
   protected void writeIncomingRecords() throws IOException {
       // write out any pending records (this can happen when inserts are 
turned into updates)
       Iterator<HoodieRecord<T>> newRecordsItr = (keyToNewRecords instanceof 
ExternalSpillableMap)
           ? ((ExternalSpillableMap)keyToNewRecords).iterator() : 
keyToNewRecords.values().iterator();
       while (newRecordsItr.hasNext()) {
         HoodieRecord<T> hoodieRecord = newRecordsItr.next();
         if (!writtenRecordKeys.contains(hoodieRecord.getRecordKey())) {
           writeInsertRecord(hoodieRecord);
         }
       }
     }
   ```
   , after 
https://github.com/apache/hudi/commit/f8028a400ebe7a64d7745fae90e769306a8a07a7, 
the map is changes to be as immutabe, thus `keyToNewRecords.values()` is 
invoked and throws error!
   
   ### Impact
   
   FIx the compaction code path
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, 
config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the 
default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. 
Please create a Jira ticket, attach the
     ticket number here and follow the 
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to 
make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to