pratyakshsharma commented on pull request #1648: URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-632611762
> @pratyakshsharma : was this patch already reviewed as part of #1597? or do I need to review it from scratch The changes in https://github.com/apache/incubator-hudi/pull/1597 were done by creating a separate class (MultiFormatTimestampBasedKeyGenerator). In this PR, I have tried to include all the changes in already existing TimestampBasedKeyGenerator class. So you need to take a look from scratch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
