sathyaprakashg opened a new pull request #1654:
URL: https://github.com/apache/incubator-hudi/pull/1654


   ## What is the purpose of the pull request
   
   inlineCompactionEvery method in HoodieCompactionConfig.Builder is 
incorrectly setting number of delta commits to INLINE_COMPACT_PROP property 
which is boolean variable
    
   I think withMaxNumDeltaCommitsBeforeCompaction method is doing the purpose 
of setting num of delta commits before compaction. 
   
   So, I am proposing to remove inlineCompactionEvery method, which is not used 
anywhere
   
   ## Brief change log
   
     - *Remove inlineCompactionEvery method from HoodieCompactionConfig.Builder*
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test 
coverage.
   
   ## Committer checklist
   
    - [x ] Has a corresponding JIRA in PR title & commit
    
    - [x ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to