codope commented on code in PR #7917:
URL: https://github.com/apache/hudi/pull/7917#discussion_r1102295643
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/HoodieSparkKryoRegistrar.scala:
##########
@@ -44,12 +45,15 @@ import org.apache.spark.serializer.KryoRegistrator
* </ol>
*/
class HoodieSparkKryoRegistrar extends HoodieCommonKryoRegistrar with
KryoRegistrator {
+
override def registerClasses(kryo: Kryo): Unit = {
///////////////////////////////////////////////////////////////////////////
// NOTE: DO NOT REORDER REGISTRATIONS
///////////////////////////////////////////////////////////////////////////
super[HoodieCommonKryoRegistrar].registerClasses(kryo)
+ kryo.register(classOf[HoodieKey], new HoodieKeySerializer)
Review Comment:
so we need this because we still want to be able to make use of serde
optimization between shuffles?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java:
##########
@@ -97,6 +97,7 @@ public DeleteRecord[] getRecordsToDelete() {
}
}
+ // TODO(HUDI-5760) avoid using Kryo for serialization here
Review Comment:
Is this comment misplaced? I am assuming this is to avoid Kryo for
serialization to disk. So, it should be placed before `getContentBytes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
