yihua commented on code in PR #7921:
URL: https://github.com/apache/hudi/pull/7921#discussion_r1103486098
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1125,7 +1130,10 @@ private void initialCommit(String createInstantTime,
List<MetadataPartitionType>
LOG.info("Committing " + partitions.size() + " partitions and " +
totalDataFilesCount + " files to metadata");
}
- commit(createInstantTime, partitionToRecordsMap, false);
+ String commitInstantTime =
Review Comment:
Based on my understanding, `createInstantTime` is used in two places:
- For `files` partition: `getFilesPartitionRecords(createInstantTime,
partitionInfoList, allPartitionRecord)`, `createInstantTime` is used to
determine the file list till the instant time in data table. So this should
not have the suffix.
- For `bloom_filters` partition:
`HoodieTableMetadataUtil.convertFilesToBloomFilterRecords(
engineContext, Collections.emptyMap(), partitionToFilesMap,
getRecordsGenerationParams(), createInstantTime)`, `createInstantTime` is
stored in the metadata table record. Not sure how important this is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
