bvaradar commented on a change in pull request #1654:
URL: https://github.com/apache/hudi/pull/1654#discussion_r429610603
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java
##########
@@ -147,11 +147,6 @@ public Builder withInlineCompaction(Boolean
inlineCompaction) {
return this;
}
- public Builder inlineCompactionEvery(int deltaCommits) {
- props.setProperty(INLINE_COMPACT_PROP, String.valueOf(deltaCommits));
Review comment:
@sathyaprakashg : Thanks for catching this.
Yes, this method should not be there in the first place.
Though, For context, this is innocuous as Hudi uses the property
hoodie.compact.inline.max.delta.commits for figure out inline compaction
interval. The associated set API is
withMaxNumDeltaCommitsBeforeCompaction()(https://hudi.apache.org/docs/configurations.html#withMaxNumDeltaCommitsBeforeCompaction).
Can you try setting this value : hoodie.compact.inline.max.delta.commits to a
higher value ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
