bvaradar commented on a change in pull request #1616:
URL: https://github.com/apache/hudi/pull/1616#discussion_r429611682



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/fs/inline/InLineFsDataInputStream.java
##########
@@ -56,24 +60,32 @@ public long getPos() throws IOException {
 
   @Override
   public int read(long position, byte[] buffer, int offset, int length) throws 
IOException {
+    if ((length - offset) > this.length) {

Review comment:
       I think the condition be length + offset > this.length. Right ? Can you 
please check 

##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/fs/inline/InLineFsDataInputStream.java
##########
@@ -56,24 +60,32 @@ public long getPos() throws IOException {
 
   @Override
   public int read(long position, byte[] buffer, int offset, int length) throws 
IOException {
+    if ((length - offset) > this.length) {

Review comment:
       @nsivabalan : ^^




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to