bvaradar commented on code in PR #7840:
URL: https://github.com/apache/hudi/pull/7840#discussion_r1109184358


##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java:
##########
@@ -452,6 +452,8 @@ private byte[] decompressBytes(final byte[] bytes) throws 
IOException {
         return decompressBaos.toByteArray();
       } catch (IOException e) {
         throw new HoodieIOException("IOException while decompressing bytes", 
e);
+      } finally {

Review Comment:
   @TengHuo : Thanks for the PR. To be defensive, can you also update line 446 
so that the initialization is within the try block. Rest looks good. 
   InputStream in = null;
   try
   {
       in = new InflaterInputStream(new ByteArrayInputStream(bytes));
       ......
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to