SteNicholas commented on code in PR #7995:
URL: https://github.com/apache/hudi/pull/7995#discussion_r1111859227
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -259,6 +259,8 @@ private void resetFileGroupsReplaced(HoodieTimeline
timeline) {
public void close() {
try {
writeLock.lock();
+ this.metaClient = null;
+ this.visibleCommitsAndCompactionTimeline = null;
Review Comment:
Does the `writeLock` set to null?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -259,6 +259,8 @@ private void resetFileGroupsReplaced(HoodieTimeline
timeline) {
public void close() {
try {
writeLock.lock();
+ this.metaClient = null;
+ this.visibleCommitsAndCompactionTimeline = null;
Review Comment:
Does the `writeLock` need to set to null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
