danny0405 commented on code in PR #7159:
URL: https://github.com/apache/hudi/pull/7159#discussion_r1112774841
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1591,10 +1591,18 @@ public int getSkipPartitionsFromLatestForClustering() {
return
getInt(HoodieClusteringConfig.PLAN_STRATEGY_SKIP_PARTITIONS_FROM_LATEST);
}
+ public boolean isClusteringForce() {
+ return getBoolean(HoodieClusteringConfig.PLAN_STRATEGY_FORCE);
+ }
Review Comment:
`isClusteringForce` -> `isSingleGroupClusteringEnabled`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##########
@@ -182,6 +182,12 @@ public class HoodieClusteringConfig extends HoodieConfig {
.sinceVersion("0.7.0")
.withDocumentation("Each group can produce 'N'
(CLUSTERING_MAX_GROUP_SIZE/CLUSTERING_TARGET_FILE_SIZE) output file groups");
+ public static final ConfigProperty<Boolean> PLAN_STRATEGY_FORCE =
ConfigProperty
+ .key(CLUSTERING_STRATEGY_PARAM_PREFIX + "force")
+ .defaultValue(true)
+ .sinceVersion("0.12.2")
+ .withDocumentation("Force include all files involved, regardless of the
sort.columns configuration and number of files.");
Review Comment:
Are you sure it is since `0.12.2` ?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##########
@@ -182,6 +182,12 @@ public class HoodieClusteringConfig extends HoodieConfig {
.sinceVersion("0.7.0")
.withDocumentation("Each group can produce 'N'
(CLUSTERING_MAX_GROUP_SIZE/CLUSTERING_TARGET_FILE_SIZE) output file groups");
+ public static final ConfigProperty<Boolean> PLAN_STRATEGY_FORCE =
ConfigProperty
+ .key(CLUSTERING_STRATEGY_PARAM_PREFIX + "force")
+ .defaultValue(true)
Review Comment:
how about this option
`hoodie.clustering.plan.strategy.single.group.cluster.enabled` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
