nsivabalan commented on a change in pull request #1648: URL: https://github.com/apache/hudi/pull/1648#discussion_r429660204
########## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/parser/HoodieDateTimeParser.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.keygen.parser; + +import org.joda.time.DateTimeZone; +import org.joda.time.format.DateTimeFormatter; + +public interface HoodieDateTimeParser { + + /** + * Returns the output date format in which the partition paths will be created for the hudi dataset. + * @return + */ + String getOutputDateFormat(); Review comment: actually my bad. just now it strikes me. Lets add an arg for the config params. If we leave it completely to the parser, then we can't enforce the parameter used. Each impl can define their own params. Lets not leave it loose like that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
