nsivabalan commented on code in PR #8037:
URL: https://github.com/apache/hudi/pull/8037#discussion_r1116710210
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3042,7 +3043,9 @@ private String getDefaultMarkersType(EngineType
engineType) {
if (writeConfig.isEmbeddedTimelineServerEnabled()) {
return MarkerType.TIMELINE_SERVER_BASED.toString();
} else {
- LOG.warn("Embedded timeline server is disabled, fallback to use
direct marker type for spark");
+ if
(!HoodieTableMetadata.isMetadataTable(this.writeConfig.getBasePath())) {
Review Comment:
this is unrelated change.
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java:
##########
@@ -712,7 +711,7 @@ private Pair<Option<String>, JavaRDD<WriteStatus>>
writeToSink(JavaRDD<HoodieRec
String commitActionType = CommitUtils.getCommitActionType(cfg.operation,
HoodieTableType.valueOf(cfg.tableType));
boolean success = writeClient.commit(instantTime, writeStatusRDD,
Option.of(checkpointCommitMetadata), commitActionType, Collections.emptyMap());
if (success) {
- LOG.info("Commit " + instantTime + " successful!");
+ LOG.warn("Commit " + instantTime + " successful! " +
counter.incrementAndGet());
Review Comment:
to print out the number of commits succeeded w/ deltastreamer continuous
mode.
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java:
##########
@@ -916,10 +915,10 @@ private HoodieWriteConfig getHoodieClientConfig(Schema
schema) {
HoodieClusteringConfig clusteringConfig =
HoodieClusteringConfig.from(props);
// Validate what deltastreamer assumes of write-config to be really safe
- ValidationUtils.checkArgument(config.inlineCompactionEnabled() ==
cfg.isInlineCompactionEnabled(),
- String.format("%s should be set to %s", INLINE_COMPACT.key(),
cfg.isInlineCompactionEnabled()));
- ValidationUtils.checkArgument(config.inlineClusteringEnabled() ==
clusteringConfig.isInlineClusteringEnabled(),
- String.format("%s should be set to %s", INLINE_CLUSTERING.key(),
clusteringConfig.isInlineClusteringEnabled()));
+ //ValidationUtils.checkArgument(config.inlineCompactionEnabled() ==
cfg.isInlineCompactionEnabled(),
Review Comment:
by default inline compaction is not feasible w/ MDT. hence had to remove
these conditions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
