XuQianJin-Stars commented on code in PR #8024:
URL: https://github.com/apache/hudi/pull/8024#discussion_r1116830778
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RollbackToInstantTimeProcedure.scala:
##########
@@ -38,7 +37,8 @@ class RollbackToInstantTimeProcedure extends BaseProcedure
with ProcedureBuilder
ProcedureParameter.required(1, "instant_time", DataTypes.StringType, None))
private val OUTPUT_TYPE = new StructType(Array[StructField](
- StructField("rollback_result", DataTypes.BooleanType, nullable = true,
Metadata.empty))
+ StructField("rollback_result", DataTypes.BooleanType, nullable = true,
Metadata.empty),
+ StructField("instant_time", DataTypes.StringType, nullable = true,
Metadata.empty))
Review Comment:
> Like `rollback_to_savepoint`, the request argument of
`rollback_to_instant` has the `instant_time`, therefore the return result
doesn't need the `instant_time`.
This will iteratively output multiple lines of rollback instants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
