sathyaprakashg commented on a change in pull request #1654:
URL: https://github.com/apache/hudi/pull/1654#discussion_r429786339
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java
##########
@@ -147,11 +147,6 @@ public Builder withInlineCompaction(Boolean
inlineCompaction) {
return this;
}
- public Builder inlineCompactionEvery(int deltaCommits) {
- props.setProperty(INLINE_COMPACT_PROP, String.valueOf(deltaCommits));
Review comment:
Thanks @vinothchandar and @bvaradar for the information.
I see that currently, default value of
hoodie.compact.inline.max.delta.commits is 1 and it is making merge on read
table to do inline compaction during every load. We can set custom value in
specific load, but it could be better if default value is higher than 1, so
that MOR table does not behave like COW table by recreating affected parquet
file every time.
I created MR for this. Please review and let me know your thoughts.
https://github.com/apache/hudi/pull/1664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
