danny0405 commented on code in PR #8050:
URL: https://github.com/apache/hudi/pull/8050#discussion_r1118314626
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##########
@@ -98,8 +98,6 @@ public HiveSyncConfig(Properties props, Configuration
hadoopConf) {
super(props, hadoopConf);
HiveConf hiveConf = hadoopConf instanceof HiveConf
? (HiveConf) hadoopConf : new HiveConf(hadoopConf, HiveConf.class);
- // HiveConf needs to load fs conf to allow instantiation via
AWSGlueClientFactory
- hiveConf.addResource(getHadoopFileSystem().getConf());
Review Comment:
This line causes the object reference leak, we should never modify passed in
param directly, the param should be immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
