nsivabalan commented on code in PR #7982:
URL: https://github.com/apache/hudi/pull/7982#discussion_r1118380323
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java:
##########
@@ -710,6 +765,26 @@ private Pair<Option<String>, JavaRDD<WriteStatus>>
writeToSink(JavaRDD<HoodieRec
+ totalErrorRecords + "/" + totalRecords);
}
String commitActionType = CommitUtils.getCommitActionType(cfg.operation,
HoodieTableType.valueOf(cfg.tableType));
Review Comment:
I don't think we need to address this right away, but lets think if it makes
sense.
for error records from WriteStatusRdd, should we also route them to error
table. I vaguely remember a user from the community asking, if hudi can ignore
such error records and commit rest of the valid data long time back.
and since we are adding support for error table, may be we should consider
routing failed records to the error table as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
