danny0405 commented on code in PR #7997:
URL: https://github.com/apache/hudi/pull/7997#discussion_r1118389369
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java:
##########
@@ -122,7 +129,24 @@ public HoodieFileGroupId getFileGroupId() {
* some log files, that are based off a commit or delta commit.
*/
private boolean isFileSliceCommitted(FileSlice slice) {
- if (!compareTimestamps(slice.getBaseInstantTime(), LESSER_THAN_OR_EQUALS,
lastInstant.get().getTimestamp())) {
+ if (compareTimestamps(slice.getBaseInstantTime(), GREATER_THAN,
lastInstant.get().getTimestamp())) {
+ return false;
+ }
+
+ if (!slice.getBaseFile().isPresent() &&
timeline.isBeforeTimelineStarts(slice.getBaseInstantTime())) {
Review Comment:
I don't think this is a Flink specific bug, agree with @bvaradar somehow the
MOR log rollback or the fs view(maybe related with metadata) should be fixed,
let's create another JIRA issue to track the improvement.
Eradicating the bug from the root cause takes some time, I also agree
@voonhous we can have a quick fix on Flink side.
@voonhous The PR overall looks good, can we move the tests into
`ITTestDataStreamWrite` to reuse some tool methods, or can we re-organize these
two test cases for some reuse things, because there are alreay bucket index
tests in `ITTestDataStreamWrite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
