[GitHub] [hudi] sandyfog commented on a diff in pull request #7886: [HUDI-5726] Fix timestamp field is 8 hours longer than the time

Mon, 27 Feb 2023 02:08:56 -0800 


sandyfog commented on code in PR #7886:
URL: https://github.com/apache/hudi/pull/7886#discussion_r1118529786


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/AvroToRowDataConverters.java:
##########
@@ -233,7 +234,9 @@ private static AvroToRowDataConverter 
createTimestampConverter(int precision) {
               "Unexpected object type for TIMESTAMP logical type. Received: " 
+ avroObject);
         }
       }
-      return TimestampData.fromInstant(instant);
+      Timestamp timestamp = new Timestamp(instant.toEpochMilli());
+      timestamp.setNanos(instant.getNano());
+      return TimestampData.fromTimestamp(timestamp);

Review Comment:
   I seeļ¼Œthis pr  mainly used local timezone  to solve hive  8 hours  late 
issues,  so we  can close this pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to