nsivabalan commented on code in PR #7914:
URL: https://github.com/apache/hudi/pull/7914#discussion_r1119346610
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/common/HoodieFlinkEngineContext.java:
##########
@@ -166,17 +167,17 @@ public void setJobStatus(String activeModule, String
activityDescription) {
}
@Override
- public void putCachedDataIds(String basePath, String instantTime, int...
ids) {
+ public void putCachedDataIds(HoodieDataCacheKey cacheKey, int... ids) {
Review Comment:
may be in a follow up patch.
why can't we support persisting and unpersisting for other engines too?
##########
hudi-common/src/main/java/org/apache/hudi/common/data/HoodieData.java:
##########
@@ -56,10 +58,19 @@
int getId();
/**
- * Persists the data w/ provided {@code level} (if applicable)
+ * Persists the data w/ provided {@code level} (if applicable).
+ *
+ * Use this method only when you call {@link #unpersist()} at some later
point for the same {@link HoodieData}.
+ * Otherwise, use {@link #persist(String, HoodieEngineContext,
HoodieDataCacheKey)} instead for auto-unpersist
+ * at the end of a client write operation.
*/
void persist(String level);
+ /**
+ * Persists the data w/ provided {@code level} (if applicable), and cache it
within the {@code engineContext}.
Review Comment:
minor.
".... and cache the Rdd ids within the ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
