xushiyan commented on code in PR #7951:
URL: https://github.com/apache/hudi/pull/7951#discussion_r1120551966
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -643,8 +736,9 @@ class TestCOWDataSource extends HoodieSparkClientTestBase
with ScalaAssertionSup
def testSparkPartitionByWithCustomKeyGenerator(recordType:
HoodieRecordType): Unit = {
val (writeOpts, readOpts) = getWriterReaderOpts(recordType)
+ val updatedWriteOpts =
writeOpts.-(KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME.key())
Review Comment:
some cases we need to remove PARTITIONPATH_FIELD_NAME and some cases we
don't. this test logic will be hard to maintain. can we avoid special handling
like this? as CI passed, we can land once the test is fixed and passed locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
