vinothchandar commented on code in PR #5965:
URL: https://github.com/apache/hudi/pull/5965#discussion_r1122666424
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java:
##########
@@ -106,12 +106,7 @@ public static void main(String[] args) {
String dirName = new Path(cfg.basePath).getName();
JavaSparkContext jssc = UtilHelpers.buildSparkContext("hoodie-cleaner-" +
dirName, cfg.sparkMaster);
- try {
- new HoodieCleaner(cfg, jssc).run();
- } catch (Throwable throwable) {
- LOG.error("Fail to run cleaning for " + cfg.basePath, throwable);
- } finally {
- jssc.stop();
Review Comment:
could we just call `System.exit(1)` or a non-zero exit code. I think we can
keep the spark context stopping that way and still meet the airflow issue
@haggy brought up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]