xicm commented on code in PR #8057:
URL: https://github.com/apache/hudi/pull/8057#discussion_r1124146982
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -834,7 +834,7 @@ private HoodieWriteConfig
buildWriteConfigForEarlyConflictDetect(String markerTy
// the running interval of the async conflict detector so that the
conflict can
// be detected before the marker requests are processed at the
timeline server
// in the test.
- .withMarkersTimelineServerBasedBatchIntervalMs(1000)
+ .withMarkersTimelineServerBasedBatchIntervalMs(10000)
Review Comment:
I run the test locally and find that we may call hasMarkerConflict before
first detection is finished in AsyncTimelineServerBasedDetectionStrategy. So I
increase the delay of schedule the marker creation request.
It will be better if we have a mechanism to ensure returning detection
result after first detection is finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
