yihua commented on code in PR #8079:
URL: https://github.com/apache/hudi/pull/8079#discussion_r1125390671
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -269,19 +269,35 @@ public void close() {
/**
* Clears the partition Map and reset view states.
+ * <p>
+ * NOTE: This method SHOULD NOT BE OVERRIDDEN which may cause stale file
system view
+ * to be served. Instead, override {@link
AbstractTableFileSystemView#runReset} to
+ * add custom logic.
*/
@Override
public void reset() {
try {
writeLock.lock();
- clear();
- // Initialize with new Hoodie timeline.
- init(metaClient, getTimeline());
+ runReset();
} finally {
writeLock.unlock();
}
}
+ /**
+ * Resets the view states, which can be overridden by subclasses. This
reset logic is guarded
+ * by the write lock.
+ * <p>
+ * NOTE: This method SHOULD BE OVERRIDDEN for any custom logic. DO NOT
OVERRIDE
Review Comment:
No longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
