danny0405 commented on code in PR #8098:
URL: https://github.com/apache/hudi/pull/8098#discussion_r1127414889
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -75,7 +76,7 @@ public DynamicTableSource createDynamicTableSource(Context
context) {
Path path = new Path(conf.getOptional(FlinkOptions.PATH).orElseThrow(() ->
new ValidationException("Option [path] should not be empty.")));
setupTableOptions(conf.getString(FlinkOptions.PATH), conf);
- ResolvedSchema schema = context.getCatalogTable().getResolvedSchema();
+ ResolvedSchema schema =
ResolvedSchema.of(context.getCatalogTable().getResolvedSchema().getColumns().stream().filter(c->
!(c instanceof Column.ComputedColumn)).collect(Collectors.toList()));
setupConfOptions(conf, context.getObjectIdentifier(),
context.getCatalogTable(), schema);
Review Comment:
in `ITTestHoodieDataSource.testWriteReadWithComputedColumns` we add a test
case for the computed column and it works correctly, can you explain a little
more why the `proc_time` column failes instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
