bvaradar commented on code in PR #7680:
URL: https://github.com/apache/hudi/pull/7680#discussion_r1133151769


##########
hudi-spark-datasource/hudi-spark3.2plus-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterTableCommand.scala:
##########
@@ -179,37 +184,6 @@ case class AlterTableCommand(table: CatalogTable, changes: 
Seq[TableChange], cha
     logInfo("column update finished")
   }
 
-  // to do support unset default value to columns, and apply them to 
internalSchema

Review Comment:
   Are we essentially moving this part in Spark 3.1 and 3.2 to 
AlterHoodieTable[Un]Set class ? What are the side effects here ? Are we 
disallowing existing mechanisms to set/unset props with this change ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to