kkrugler commented on PR #7955: URL: https://github.com/apache/hudi/pull/7955#issuecomment-1468080255
@vinothchandar - to address some of your questions: > How does this affect bundling? we bundle slf4j? we need to think if anything is going to break across majjor engines, environments. You should only have a dependency on the slf4j API in most jars. A few stand-alone jars (like the CLI) would also want a dependency on the `log4j-slf4j-impl` connector, which will pull in the log4j jar transitively. These stand-alone jars would also want to have their own `log4j*.properties` file. > how are all the existing `log4j.properties` affected? across the project. These should only be in `test/resources`, other than for stand-alone jars (as per above). Otherwise you're relying on the project that's using Hudi to provide an appropriate logging configuration file, based on the logging framework they're using. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
