yihua commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1136097088
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -69,6 +69,10 @@ public class HoodieIndexConfig extends HoodieConfig {
private static final Logger LOG =
LogManager.getLogger(HoodieIndexConfig.class);
+ public static final boolean DEFAULT_BLOOM_INDEX_UPDATE_PARTITION_PATH = true;
+ public static final boolean DEFAULT_SIMPLE_INDEX_UPDATE_PARTITION_PATH =
true;
+
+
Review Comment:
We'll keep the configs: `hoodie.bloom.index.update.partition.path` and
`hoodie.simple.index.update.partition.path`. Some users may still want them to
be `false`.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringOperator.java:
##########
@@ -133,7 +133,7 @@ public class ClusteringOperator extends
TableStreamOperator<ClusteringCommitEven
public ClusteringOperator(Configuration conf, RowType rowType) {
this.conf = conf;
- this.preserveHoodieMetadata =
conf.getBoolean(HoodieClusteringConfig.PRESERVE_COMMIT_METADATA.key(),
HoodieClusteringConfig.PRESERVE_COMMIT_METADATA.defaultValue());
+ this.preserveHoodieMetadata =
HoodieClusteringConfig.DEFAULT_PRESERVE_COMMIT_METADATA;
Review Comment:
Fixed.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java:
##########
@@ -199,13 +199,8 @@ private static Stream<Arguments>
populateMetaFieldsParams() {
return Arrays.stream(new Boolean[][] {{true}, {false}}).map(Arguments::of);
}
- private static Stream<Arguments>
populateMetaFieldsAndPreserveMetadataParams() {
- return Arrays.stream(new Boolean[][] {
- {true, true},
- {false, true},
- {true, false},
- {false, false}
- }).map(Arguments::of);
+ private static Stream<Arguments> populateMetaFields() {
Review Comment:
This method is no longer needed and we can reuse
`populateMetaFieldsParams()`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##########
@@ -48,6 +48,8 @@
+ "which optimizes the storage layout for better query performance by
sorting and sizing data files.")
public class HoodieClusteringConfig extends HoodieConfig {
+ public static final boolean DEFAULT_PRESERVE_COMMIT_METADATA = true;
Review Comment:
These are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
