XuQianJin-Stars commented on code in PR #8188:
URL: https://github.com/apache/hudi/pull/8188#discussion_r1138216544
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/TimeWait.java:
##########
@@ -54,10 +54,11 @@ public static Builder builder() {
public void waitFor() {
try {
if (waitingTime > timeout) {
- throw new HoodieException("Timeout(" + waitingTime + "ms) while
waiting for " + action);
+ LOG.warn("Timeout(" + waitingTime + "ms) while waiting for " + action);
Review Comment:
> I have a question: when `waitingTime > timeout`, function `waitFor()` will
return without sleep, and will the AbstractStreamWriteFunction::instantToWrite
go busy loop waiting for new commit.requested instant?
In the case of a lot of parallelism, the cost of job restart is also very
high.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
