yihua commented on code in PR #8152:
URL: https://github.com/apache/hudi/pull/8152#discussion_r1139271824
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/KafkaOffsetPostProcessor.java:
##########
@@ -36,15 +36,8 @@
public class KafkaOffsetPostProcessor extends SchemaPostProcessor {
public static class Config {
- public static final ConfigProperty<String> KAFKA_APPEND_OFFSETS =
ConfigProperty
Review Comment:
Fixed.
##########
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieInlineTestSuiteWriter.java:
##########
@@ -189,7 +190,7 @@ public void commit(JavaRDD<WriteStatus> records,
JavaRDD<DeltaWriteStats> genera
Map<String, String> extraMetadata = new HashMap<>();
/** Store the checkpoint in the commit metadata just like
* {@link HoodieDeltaStreamer#commit(SparkRDDWriteClient, JavaRDD,
Option)} **/
- extraMetadata.put(HoodieDeltaStreamerWrapper.CHECKPOINT_KEY,
lastCheckpoint.get());
+ extraMetadata.put(HoodieDeltaStreamer.CHECKPOINT_KEY,
lastCheckpoint.get());
Review Comment:
Actually good to have this to standardize the reference.
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/ProtoClassBasedSchemaProvider.java:
##########
@@ -35,35 +35,6 @@
* A schema provider that takes in a class name for a generated protobuf class
that is on the classpath.
*/
public class ProtoClassBasedSchemaProvider extends SchemaProvider {
- /**
- * Configs supported.
- */
- public static class Config {
- private static final String PROTO_SCHEMA_PROVIDER_PREFIX =
"hoodie.deltastreamer.schemaprovider.proto";
- public static final ConfigProperty<String> PROTO_SCHEMA_CLASS_NAME =
ConfigProperty.key(PROTO_SCHEMA_PROVIDER_PREFIX + ".class.name")
Review Comment:
Fixed.
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/ProtoClassBasedSchemaProvider.java:
##########
@@ -35,35 +35,6 @@
* A schema provider that takes in a class name for a generated protobuf class
that is on the classpath.
*/
public class ProtoClassBasedSchemaProvider extends SchemaProvider {
- /**
- * Configs supported.
- */
- public static class Config {
- private static final String PROTO_SCHEMA_PROVIDER_PREFIX =
"hoodie.deltastreamer.schemaprovider.proto";
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
