leesf commented on PR #7614: URL: https://github.com/apache/hudi/pull/7614#issuecomment-1472950797
> @fengjian428, @leesf, could you confirm whether the `supportAtomicCreation` of other schemes is true? Otherwise the file lock provider user will update the source code and compile a version, then enable to use the file lock provider. Meanwhile, if the user uses the filesystem lock provider on viewfs in 0.13 version without this check, it isn't user-friendly for this change because the user couldn't use the filesystem lock provider redirectly after this change. BTW, could you document this check in the document? IMO, the user isn't telt that the filesystem lock provider depends on the scheme itself that supports atomic creation. Agree, if we do not tested all schemes, then we could use config to control the behavior to avoid users modify code, @fengjian428 WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
