yihua commented on PR #8080: URL: https://github.com/apache/hudi/pull/8080#issuecomment-1474754288
@yuzhaojing Thanks for the suggestion. > 1. Add unit tests to confirm that the table service client has not made unexpected modifications to writeConfig. I added three tests to make sure that the write config is not modified if the timeline server instance is passed in and the timeline server used by the write client and corresponding table service client is the same. > 2. Confirm that the table service of the table service client is scheduled and executed normally. > 3. Call correctly after starting the managed service. These are already covered by existing table service tests, so I feel we don't have to test the table service client independently. If new tests are really needed, you can put up a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
