yihua commented on code in PR #8029:
URL: https://github.com/apache/hudi/pull/8029#discussion_r1145545183
##########
hudi-common/src/main/resources/hbase-site.xml:
##########
@@ -158,7 +158,7 @@ possible configurations would overwhelm and obscure the
important.
<property>
<name>hbase.master.logcleaner.plugins</name>
<value>
-
org.apache.hadoop.hbase.master.cleaner.TimeToLiveLogCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveProcedureWALCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveMasterLocalStoreWALCleaner
+
org.apache.hudi.org.apache.hadoop.hbase.master.cleaner.TimeToLiveLogCleaner,org.apache.hudi.org.apache.hadoop.hbase.master.cleaner.TimeToLiveProcedureWALCleaner,org.apache.hudi.org.apache.hadoop.hbase.master.cleaner.TimeToLiveMasterLocalStoreWALCleaner
Review Comment:
Reading and writing HFile do not require some of the HBase configs,
including the ones fixed by this PR, so solely for reading and writing the
metadata table, there should not be any issue. But if other HBase
functionality is used elsewhere and the Hudi jar is loaded first by the class
loader, the unshaded class names can cause problems.
We need all the configs as they are required for HBase 2.4.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
