xicm commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1146010560
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java:
##########
@@ -78,7 +78,7 @@ public static Option<HoodieCommitMetadata>
resolveWriteConflictIfAny(
final ConcurrentOperation thisOperation = new
ConcurrentOperation(currentTxnOwnerInstant.get(), thisCommitMetadata.orElse(new
HoodieCommitMetadata()));
instantStream.forEach(instant -> {
try {
- ConcurrentOperation otherOperation = new
ConcurrentOperation(instant, table.getMetaClient());
+ ConcurrentOperation otherOperation = new
ConcurrentOperation(instant, TimelineUtils.getCommitMetadata(instant,
table.getActiveTimeline()));
if (resolutionStrategy.hasConflict(thisOperation, otherOperation)) {
Review Comment:
I think I find the reason. The instant may be compaction.request, in this
case we can't use TimelineUtils.getCommitMetadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
