voonhous commented on code in PR #8298:
URL: https://github.com/apache/hudi/pull/8298#discussion_r1148839127
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/SparkHoodieTableFileIndex.scala:
##########
@@ -281,14 +281,15 @@ class SparkHoodieTableFileIndex(spark: SparkSession,
// Static partition-path prefix is defined as a prefix of the full
partition-path where only
// first N partition columns (in-order) have proper (static) values bound
in equality predicates,
// allowing in turn to build such prefix to be used in subsequent filtering
- val staticPartitionColumnNameValuePairs: Seq[(String, Any)] = {
+ val staticPartitionColumnNameValuePairs: Seq[(String, (String, Any))] = {
// Extract from simple predicates of the form `date = '2022-01-01'` both
// partition column and corresponding (literal) value
- val staticPartitionColumnValuesMap =
extractEqualityPredicatesLiteralValues(partitionColumnPredicates)
+ val zoneId = configProperties.getString(DateTimeUtils.TIMEZONE_OPTION,
SQLConf.get.sessionLocalTimeZone)
Review Comment:
To standardise the usage of how `TIMEZONE_OPTION` is fetched from
configProperties that has already been used here:
https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/SparkHoodieTableFileIndex.scala#L392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
