lokeshj1703 commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1152831160


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
         .withCompactionConfig(HoodieCompactionConfig.newBuilder()
             .withInlineCompaction(false)
             
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
-            // by default, the HFile does not keep the metadata fields, set up 
as false
-            // to always use the metadata of the new record.
-            .withPreserveCommitMetadata(false)

Review Comment:
   Yeah. I had my doubts about this as well. I made an attempt to revert to old 
behavior. Please let me know if it looks okay. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to