boneanxs commented on PR #7627: URL: https://github.com/apache/hudi/pull/7627#issuecomment-1491187084
> +1 on this in general. but would this be a format change? This will have backwards compatibility issues. > there is not storage change (barring archived entry which needs to be discussed), but we add stateTransition time based on fileStatus's last mod time to every HoodieInstant Yes, there's no format/ storage changes, given the timeline instants are log based, these instants won't change after written, I use `FileStatus.getModificationTime` to represent the state transition time. This improvement works well inside my company(HDFS based), and I think it still can work under ObjectStorage, since all instants are file based, and Object Stores should show the right timestamp(https://hadoop.apache.org/docs/current//hadoop-project-dist/hadoop-common/FileSystemShell.html#Timestamps) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
