nsivabalan commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1153954231
##########
hudi-aws/src/main/java/org/apache/hudi/config/DynamoDbBasedLockConfig.java:
##########
@@ -46,7 +46,7 @@ public class DynamoDbBasedLockConfig extends HoodieConfig {
public static final ConfigProperty<String> DYNAMODB_LOCK_TABLE_NAME =
ConfigProperty
.key(DYNAMODB_BASED_LOCK_PROPERTY_PREFIX + "table")
- .noDefaultValue()
+ .defaultValue("hudi_locks")
Review Comment:
wouldn't this result in diff tables using same lock ?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java:
##########
@@ -114,7 +116,7 @@ public HoodieCreateHandle(HoodieWriteConfig config, String
instantTime, HoodieTa
public HoodieCreateHandle(HoodieWriteConfig config, String instantTime,
HoodieTable<T, I, K, O> hoodieTable,
String partitionPath, String fileId, Map<String, HoodieRecord<T>>
recordMap,
TaskContextSupplier taskContextSupplier) {
- this(config, instantTime, hoodieTable, partitionPath, fileId,
taskContextSupplier, config.isPreserveHoodieCommitMetadataForCompaction());
+ this(config, instantTime, hoodieTable, partitionPath, fileId,
taskContextSupplier,
!HoodieTableMetadata.isMetadataTable(config.getBasePath()));
Review Comment:
lets add java docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
