danny0405 commented on code in PR #8107:
URL: https://github.com/apache/hudi/pull/8107#discussion_r1153979756
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1145,6 +1145,10 @@ public String getKeyGeneratorClass() {
return getString(KEYGENERATOR_CLASS_NAME);
}
+ public boolean autoGenerateRecordKeys() {
+ return getBooleanOrDefault(HoodieTableConfig.AUTO_GENERATE_RECORD_KEYS);
+ }
Review Comment:
Can we eliminate this option? We can infter keyless ingestion from 2 other
options:
1. the write operation is defined as `INSERT`;
2. or user does not declare any `record.key` fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]